| Subject: | 1) This class shouldn't contain HTTP... |
|---|
| Summary: | Package rating comment |
|---|
| Messages: | 1 |
|---|
| Author: | Artur Graniszewski |
|---|
| Date: | 2010-08-12 09:12:52 |
|---|
| |
|
|
Artur Graniszewski rated this package as follows:
| Utility: | Insufficient |
|---|
| Consistency: | Sufficient |
|---|
|
|
 Artur Graniszewski - 2010-08-12 09:12:52 1) This class shouldn't contain HTTP URL's in its source code, because ping (ICMP) operates only on host names, not on full URLs (for example there is no difference between microsoft.com and microsoft.com/aa)
2) Why someone should use such a big class to do one exec("ping ...") function? This class can be 2 written in max 3 lines of code.
3) Use of exec function is not recommended because of security and performance reasons, nor is supported by a majority of shared hostings.
|
